Add llvm-binary-utilities to .github/CODEOWNERS #65545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
commented
Sep 6, 2023
.github/CODEOWNERS
Outdated
| @@ -617,3 +617,33 @@ utils/bazel/llvm-project-overlay/libc/** @llvm/pr-subscribers-libc | |||
| /clang/test/CodeGen/WebAssembly/ @llvm/pr-subscribers-webassembly | |||
| /clang/test/Sema/*wasm* @llvm/pr-subscribers-webassembly | |||
| /clang/test/SemaCXX/*wasm* @llvm/pr-subscribers-webassembly | |||
|
|
|||
| # llvm-binary-utilities | |||
| /llvm/docs/CommandGuide/llvm-* @llvm/pr-subscribers-llvm-binary-utilities | |||
There was a problem hiding this comment.
Seems that https://github.com/orgs/llvm/teams/pr-subscribers-llvm-binary-utilities is present?
There was a problem hiding this comment.
This looks like the issue we ran into for lldb too. Mehdi explained it here: https://discourse.llvm.org/t/input-needed-teams-for-pull-request-subscriptions/73116/89
There was a problem hiding this comment.
I know, but I got a warning when the team is actually present:)
MaskRay
force-pushed
the
codeowners-llvm-binary-utilitizes
branch
from
bccd126 to
8b93cb7
Compare
|
Merging this as we have some changes that do not have reviewers set (e.g. some llvm-nm patches). I think this should be fixed soon. |
|
It seems that llvm-binary-utilities cannot be added as reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://discourse.llvm.org/t/input-needed-teams-for-pull-request-subscriptions/73116/3