[OpenMP] Use the more appropriate function to retrieve the thread id on OpenBSD #65553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brad0
force-pushed
the
openmp_openbsd_kmp_gettid
branch
from
c222863 to
df63b49
Compare
…on OpenBSD Use the getthrid() function instead of a syscall.
brad0
force-pushed
the
openmp_openbsd_kmp_gettid
branch
from
df63b49 to
b42c427
Compare
|
The changes are fine but what is the motivation of doing it? |
jdoerfert
approved these changes
Sep 7, 2023
If this was a few years ago I'd say for consistency as everywhere else we use the same function, but nowadays the function must be used nowadays as opposed to a syscall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the getthrid() function instead of a syscall.