-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[PEI][PowerPC] Fix false alarm of stack size limit #65559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9e1899d
Override stack threshold
0f9ea07
Correct test
8e2eba7
Rename
07084a9
Use opaque pointer
070b0a4
Correct upper bound by using LONG_MAX
f974a9e
Still use 1UL<<63
2a9916d
Elaborate more about the maximum stack size on PPC64
bzEq 826f2d6
Adjust comment and maximum stack size considering the procedure of st…
bzEq 2ebf69b
Adjust comment
bzEq 7e4e584
Put test cases in huge-frame-size.ll
bzEq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
; RUN: llc -mtriple=powerpc64-unknown-unknown < %s 2>&1 | FileCheck %s | ||
; RUN: llc -mtriple=powerpc64le-unknown-unknown < %s 2>&1 | FileCheck %s | ||
|
||
; CHECK-NOT: warning: {{.*}} stack frame size ({{.*}}) exceeds limit (4294967295) in function 'large_stack' | ||
define ptr @large_stack() { | ||
%s = alloca [281474976710656 x i8], align 1 | ||
%e = getelementptr i8, ptr %s, i64 0 | ||
ret ptr %e | ||
} | ||
|
||
; CHECK: warning: {{.*}} stack frame size ({{.*}}) exceeds limit (4294967295) in function 'warn_on_large_stack' | ||
define ptr @warn_on_large_stack() "warn-stack-size"="4294967295" { | ||
%s = alloca [281474976710656 x i8], align 1 | ||
%e = getelementptr i8, ptr %s, i64 0 | ||
ret ptr %e | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.