Skip to content

[ADT] Remove any_isa (NFC) #65636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

[ADT] Remove any_isa (NFC) #65636

merged 1 commit into from
Sep 11, 2023

Conversation

kazutakahirata
Copy link
Contributor

any_isa has been deprecated since:

commit bb7940e
Author: Sebastian Neubauer [email protected]
Date: Tue Dec 20 13:28:30 2022 +0100

@kazutakahirata
[ADT] Remove any_isa (NFC)
493b24f 
any_isa has been deprecated since:

  commit bb7940e
  Author: Sebastian Neubauer <[email protected]>
  Date:   Tue Dec 20 13:28:30 2022 +0100
@kazutakahirata
Copy link
Contributor Author

For reference, here are related activities:

According to @Flakebi:

std::any is broken until Visual Studio 2022 17.4, so we need to wait until LLVM’s minimum VS version is there. Currently, LLVM supports anything down to VS 2019.

Flakebi
Flakebi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kazutakahirata kazutakahirata merged commit 5378117 into llvm:main Sep 11, 2023
@kazutakahirata kazutakahirata deleted the pr_adt_any_deprecated branch September 11, 2023 17:33
@michaelrj-google michaelrj-google mentioned this pull request Sep 12, 2023
Merged
@vzakhari vzakhari mentioned this pull request Sep 12, 2023
Closed
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
@kazutakahirata @ZijunZhaoCCK
[ADT] Remove any_isa (NFC) (llvm#65636)
43ff1c3 
any_isa has been deprecated since:

  commit bb7940e
  Author: Sebastian Neubauer <[email protected]>
  Date:   Tue Dec 20 13:28:30 2022 +0100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flakebi Flakebi Flakebi approved these changes

@MaskRay MaskRay Awaiting requested review from MaskRay

@dwblaikie dwblaikie Awaiting requested review from dwblaikie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazutakahirata @Flakebi