-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[GlobalISel] Add constant folding support for G_FMA/G_FMAD in the combiner. #65659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
llvm/test/CodeGen/AArch64/GlobalISel/combine-constant-fold-fma.mir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py | ||
# RUN: llc -mtriple aarch64 -run-pass=aarch64-prelegalizer-combiner -verify-machineinstrs %s -o - | FileCheck %s | ||
|
||
--- | ||
name: fma | ||
liveins: | ||
- { reg: '$d0' } | ||
body: | | ||
bb.1.entry: | ||
liveins: $d0 | ||
|
||
; CHECK-LABEL: name: fma | ||
; CHECK: liveins: $d0 | ||
; CHECK-NEXT: {{ $}} | ||
; CHECK-NEXT: %res:_(s64) = G_FCONSTANT double 8.100000e+01 | ||
; CHECK-NEXT: $d0 = COPY %res(s64) | ||
; CHECK-NEXT: RET_ReallyLR implicit $d0 | ||
%a:_(s64) = G_FCONSTANT double 40.0 | ||
%b:_(s64) = G_FCONSTANT double 2.0 | ||
%c:_(s64) = G_FCONSTANT double 1.0 | ||
%res:_(s64) = G_FMA %a, %b, %c | ||
$d0 = COPY %res(s64) | ||
RET_ReallyLR implicit $d0 | ||
|
||
... | ||
|
||
--- | ||
name: fmad | ||
liveins: | ||
- { reg: '$d0' } | ||
body: | | ||
bb.1.entry: | ||
liveins: $d0 | ||
|
||
; CHECK-LABEL: name: fmad | ||
; CHECK: liveins: $d0 | ||
; CHECK-NEXT: {{ $}} | ||
; CHECK-NEXT: %res:_(s64) = G_FCONSTANT double 8.100000e+01 | ||
; CHECK-NEXT: $d0 = COPY %res(s64) | ||
; CHECK-NEXT: RET_ReallyLR implicit $d0 | ||
%a:_(s64) = G_FCONSTANT double 40.0 | ||
%b:_(s64) = G_FCONSTANT double 2.0 | ||
%c:_(s64) = G_FCONSTANT double 1.0 | ||
%res:_(s64) = G_FMAD %a, %b, %c | ||
$d0 = COPY %res(s64) | ||
RET_ReallyLR implicit $d0 | ||
|
||
... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should just fold the same as FMA, that's what the IR does for fmuladd. This is also making this host dependent on compiler choice to contract
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the whole point of having 2 different intrinsics that we have different behaviour?
Also, this isn't host dependent because this is still doing APFloat arithmetic through the operator overloads.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a codegen selected behavior. You may get fma or muladd