[clang][deps] Store common, partially-formed invocation #65677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
reviewed
Sep 7, 2023
| CI.getHeaderSearchOpts().ModulesIgnoreMacros.clear(); | ||
| } | ||
|
|
||
| return CI; |
There was a problem hiding this comment.
This is going through CowCompilerInvocation(const CompilerInvocation &X), right? Could we add an && version that steals the sub objects without copying them? Obviously less important than avoiding the per-module copies.
There was a problem hiding this comment.
Yes. I'm happy to do that in a follow-up (constantly rebasing is kinda annoying).
There was a problem hiding this comment.
Implemented in #66301.
| @@ -117,14 +112,37 @@ ModuleDepCollector::makeInvocationForModuleBuildWithoutOutputs( | |||
| CI.getFrontendOpts().ARCMTAction = FrontendOptions::ARCMT_None; | |||
| CI.getFrontendOpts().ObjCMTAction = FrontendOptions::ObjCMT_None; | |||
| CI.getFrontendOpts().MTMigrateDir.clear(); | |||
| CI.getLangOpts().ModuleName = Deps.ID.ModuleName; | |||
There was a problem hiding this comment.
We could clear this string to make sure it won't get copied.
jansvoboda11
force-pushed
the
common-ci
branch
from
7c54eae to
0b4be90
Compare
benlangmuir
approved these changes
Sep 7, 2023
jansvoboda11
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 12, 2023
We create one `CompilerInvocation` for each modular dependency we discover. This means we create a lot of copies, even though most of the invocation is the same between modules. This patch makes use of the copy-on-write flavor of `CompilerInvocation` to share the common parts, reducing memory usage and speeding up the scan.
jansvoboda11
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 5, 2023
We create one `CompilerInvocation` for each modular dependency we discover. This means we create a lot of copies, even though most of the invocation is the same between modules. This patch makes use of the copy-on-write flavor of `CompilerInvocation` to share the common parts, reducing memory usage and speeding up the scan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We create one
CompilerInvocationfor each modular dependency we discover. This means we create a lot of copies, even though most of the invocation is the same between modules. This patch makes use of the copy-on-write flavor ofCompilerInvocationto share the common parts, reducing memory usage and speeding up the scan.