Skip to content

[libc] Add is_object #65749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc/src/__support/CPP/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ add_header_library(
type_traits/is_lvalue_reference.h
type_traits/is_member_pointer.h
type_traits/is_null_pointer.h
type_traits/is_object.h
type_traits/is_pointer.h
type_traits/is_reference.h
type_traits/is_rvalue_reference.h
Expand Down
1 change: 1 addition & 0 deletions libc/src/__support/CPP/type_traits.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include "src/__support/CPP/type_traits/is_lvalue_reference.h"
#include "src/__support/CPP/type_traits/is_member_pointer.h"
#include "src/__support/CPP/type_traits/is_null_pointer.h"
#include "src/__support/CPP/type_traits/is_object.h"
#include "src/__support/CPP/type_traits/is_pointer.h"
#include "src/__support/CPP/type_traits/is_reference.h"
#include "src/__support/CPP/type_traits/is_rvalue_reference.h"
Expand Down
30 changes: 30 additions & 0 deletions libc/src/__support/CPP/type_traits/is_object.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
//===-- is_object type_traits -----------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_SUPPORT_CPP_TYPE_TRAITS_IS_OBJECT_H
#define LLVM_LIBC_SRC_SUPPORT_CPP_TYPE_TRAITS_IS_OBJECT_H

#include "src/__support/CPP/type_traits/bool_constant.h"
#include "src/__support/CPP/type_traits/is_array.h"
#include "src/__support/CPP/type_traits/is_class.h"
#include "src/__support/CPP/type_traits/is_scalar.h"
#include "src/__support/CPP/type_traits/is_union.h"
#include "src/__support/macros/attributes.h"

namespace __llvm_libc::cpp {

// is_object
template <class T>
struct is_object
: cpp::bool_constant<cpp::is_scalar_v<T> || cpp::is_array_v<T> ||
cpp::is_union_v<T> || cpp::is_class_v<T>> {};
template <class T>
LIBC_INLINE_VAR constexpr bool is_object_v = is_object<T>::value;

} // namespace __llvm_libc::cpp

#endif // LLVM_LIBC_SRC_SUPPORT_CPP_TYPE_TRAITS_IS_OBJECT_H
22 changes: 22 additions & 0 deletions libc/test/src/__support/CPP/type_traits_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,28 @@ TEST(LlvmLibcTypeTraitsTest, is_enum_enum) {

// TODO is_null_pointer

TEST(LlvmLibcTypeTraitsTest, is_object) {
EXPECT_TRUE((is_object_v<int>)); // scalar
EXPECT_TRUE((is_object_v<Struct[]>)); // array
EXPECT_TRUE((is_object_v<Union>)); // union
EXPECT_TRUE((is_object_v<Class>)); // class

// pointers are still objects
EXPECT_TRUE((is_object_v<int *>)); // scalar
EXPECT_TRUE((is_object_v<Struct(*)[]>)); // array
EXPECT_TRUE((is_object_v<Union *>)); // union
EXPECT_TRUE((is_object_v<Class *>)); // class

// reference are not objects
EXPECT_FALSE((is_object_v<int &>)); // scalar
EXPECT_FALSE((is_object_v<Struct(&)[]>)); // array
EXPECT_FALSE((is_object_v<Union &>)); // union
EXPECT_FALSE((is_object_v<Class &>)); // class

// not an object
EXPECT_FALSE((is_object_v<void>));
}

// TODO is_pointer

// TODO is_reference
Expand Down
1 change: 1 addition & 0 deletions utils/bazel/llvm-project-overlay/libc/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ libc_support_library(
"src/__support/CPP/type_traits/is_lvalue_reference.h",
"src/__support/CPP/type_traits/is_member_pointer.h",
"src/__support/CPP/type_traits/is_null_pointer.h",
"src/__support/CPP/type_traits/is_object.h",
"src/__support/CPP/type_traits/is_pointer.h",
"src/__support/CPP/type_traits/is_reference.h",
"src/__support/CPP/type_traits/is_rvalue_reference.h",
Expand Down