[flang] Improve length information in character transformational #65771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intrinsic resolution currently does not resolve constant length information for character transformational (with "sameChar") where the argument has constant length but is not a variable. It is not required to fold those expressions (only inquiry on constant expression or variable with constant length is required to be a constant expression). But constant length information for character is valuable for lowering, so I think this is a nice and easy to have.
github-actions
bot
added
the
flang
klausler
approved these changes
Sep 8, 2023
yus3710-fj
approved these changes
Sep 11, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
…m#65771) Intrinsic resolution currently does not resolve constant length information for character transformational (with "sameChar") where the argument has constant length but is not a variable or a constant expression. It is not required to fold those expressions (only inquiry on constant expression or variable with constant length is required to be a constant expression). But constant length information for character is valuable for lowering, so I think this is a nice and easy to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intrinsic resolution currently does not resolve constant length information for character transformational (with "sameChar") where the argument has constant length but is not a variable or a constant expression.
It is not required to fold those expressions (only inquiry on constant expression or variable with constant length is required to be a constant expression).
But constant length information for character is valuable for lowering, so I think this is a nice and easy to have.
Addresses my comment in #65705 (comment) where the patch is adding code to in lowering manually get constant length info into FIR type system for maxval intrinsic result instead of relying on what LEN() is able to provide.