[MLIR][Tensor] Add Destination style RewritePattern for DimOp. #65780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaitingwang
requested review from
ftynse,
nicolasvasilache and
matthias-springer
joker-eph
approved these changes
Sep 8, 2023
| @@ -579,11 +579,30 @@ struct DimOfCastOp : public OpRewritePattern<DimOp> { | |||
| return success(); | |||
| } | |||
| }; | |||
|
|
|||
| struct DimOfDestStyleOp : public OpRewritePattern<DimOp> { | |||
There was a problem hiding this comment.
Can you document the pattern?
There was a problem hiding this comment.
Thank you for the approval! I added a brief comment: "Fold dim of a destination passing style op into the dim of the corresponding init." The updated PR should be running CI now.
kaitingwang
force-pushed
the
dimop-dst-passing-canonicalize
branch
2 times, most recently
from
d9ddbab to
0623d1c
Compare
Fold dim of a destination passing op with dim of the corresponding init. This enables canonicalization to fold away unnecessary tensor.dim ops which in turn enables folding away of other operations, as can be seen in conv_tensors_dynamic where affine.min operations were folded away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables canonicalization to fold away unnecessary tensor.dim ops which in turn enables folding away of other operations, as can be seen in conv_tensors_dynamic where affine.min operations were folded away.