[libc] Generate configure.rst from the JSON config information. #65791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lntue
reviewed
Sep 8, 2023
libc/cmake/modules/LibcConfig.cmake
Outdated
| endif() | ||
| if(${group_count} EQUAL 0) | ||
| message(FATAL_ERROR "${config_file}: Does not contain any config option groups") | ||
| return() |
There was a problem hiding this comment.
Doesn't FATAL_ERROR from the line above stop cmake processing completely?
There was a problem hiding this comment.
Yes. The idea is that if there are no config option groups, there should be no config.json added at all.
There was a problem hiding this comment.
SGTM. Then the return() in this line is not needed.
lntue
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.