Skip to content

[ORC] Introduce IRPartitionLayer for common partition functionality. #66812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sunho
Copy link
Member

@sunho sunho commented Sep 19, 2023

The IR module partitioning logic has been embeded in CompileOnDemandLayer but this functionality is also required for other purpose such as re-optimization.
This patch splits that IR partitioning logic out of CompileOnDemandLayer into a new IR layer IRPartitionLayer.

A motivation behind making it into new IR layer is for the possibility of "lazy re-optimizing JIT" where we'd like to have a composition like "CompileOnDemandLayer -> IRPartitionLayer -> ReOptLayer" as well as ordinary reoptimization like "IRPartitionLayer -> ReOptLayer"

@sunho sunho requested a review from lhames September 19, 2023 20:12
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very belatedly -- LGTM!

@sunho
Copy link
Member Author

sunho commented Apr 11, 2024

Superseded by #67050. Sorry for the confusion!

@sunho sunho closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants