remove duplicate ModuleId alias #67899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Changes[clang] Remove duplicate Full diff: https://github.com/llvm/llvm-project/pull/67899.diff 1 Files Affected:
diff --git a/clang/lib/Lex/ModuleMap.cpp b/clang/lib/Lex/ModuleMap.cpp
index e8437572ebf4bf6..f65a5f145c04395 100644
--- a/clang/lib/Lex/ModuleMap.cpp
+++ b/clang/lib/Lex/ModuleMap.cpp
@@ -1551,8 +1551,6 @@ namespace clang {
/// (or the end of the file).
void skipUntil(MMToken::TokenKind K);
- using ModuleId = SmallVector<std::pair<std::string, SourceLocation>, 2>;
-
bool parseModuleId(ModuleId &Id);
void parseModuleDecl();
void parseExternModuleDecl();
|
davidstone
force-pushed
the
remove-duplicate-ModuleId-alias
branch
from
60646e9 to
9bce0ec
Compare
|
The description got a little messed up somehow, but should be fixed. |
davidstone
force-pushed
the
remove-duplicate-ModuleId-alias
branch
from
9bce0ec to
3583e04
Compare
This alias is already defined in `clang/Basic/Module.h` to the same value.
davidstone
force-pushed
the
remove-duplicate-ModuleId-alias
branch
from
3583e04 to
07dd53a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[clang] Remove duplicate
ModuleIdalias