Skip to content

[RISCV][GISel] Disable call lowering for integers larger than 2*XLen. #69144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 48 additions & 18 deletions llvm/lib/Target/RISCV/GISel/RISCVCallLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,52 @@ struct RISCVCallReturnHandler : public RISCVIncomingValueHandler {
RISCVCallLowering::RISCVCallLowering(const RISCVTargetLowering &TLI)
: CallLowering(&TLI) {}

// TODO: Support all argument types.
static bool isSupportedArgumentType(Type *T, const RISCVSubtarget &Subtarget) {
// TODO: Integers larger than 2*XLen are passed indirectly which is not
// supported yet.
if (T->isIntegerTy())
return T->getIntegerBitWidth() <= Subtarget.getXLen() * 2;
if (T->isPointerTy())
return true;
return false;
}

// TODO: Only integer, pointer and aggregate types are supported now.
static bool isSupportedReturnType(Type *T, const RISCVSubtarget &Subtarget) {
// TODO: Integers larger than 2*XLen are passed indirectly which is not
// supported yet.
if (T->isIntegerTy())
return T->getIntegerBitWidth() <= Subtarget.getXLen() * 2;
if (T->isPointerTy())
return true;

if (T->isArrayTy())
return isSupportedReturnType(T->getArrayElementType(), Subtarget);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to need a restriction on array and struct size here as well, but that can be a follow up patch.


if (T->isStructTy()) {
// For now we only allow homogeneous structs that we can manipulate with
// G_MERGE_VALUES and G_UNMERGE_VALUES
auto StructT = cast<StructType>(T);
for (unsigned i = 1, e = StructT->getNumElements(); i != e; ++i)
if (StructT->getElementType(i) != StructT->getElementType(0))
return false;
return isSupportedReturnType(StructT->getElementType(0), Subtarget);
}

return false;
}

bool RISCVCallLowering::lowerReturnVal(MachineIRBuilder &MIRBuilder,
const Value *Val,
ArrayRef<Register> VRegs,
MachineInstrBuilder &Ret) const {
if (!Val)
return true;

// TODO: Only integer, pointer and aggregate types are supported now.
if (!Val->getType()->isIntOrPtrTy() && !Val->getType()->isAggregateType())
const RISCVSubtarget &Subtarget =
MIRBuilder.getMF().getSubtarget<RISCVSubtarget>();
if (!isSupportedReturnType(Val->getType(), Subtarget))
return false;

MachineFunction &MF = MIRBuilder.getMF();
Expand Down Expand Up @@ -208,13 +245,11 @@ bool RISCVCallLowering::lowerFormalArguments(MachineIRBuilder &MIRBuilder,
if (F.isVarArg())
return false;

// TODO: Support all argument types.
const RISCVSubtarget &Subtarget =
MIRBuilder.getMF().getSubtarget<RISCVSubtarget>();
for (auto &Arg : F.args()) {
if (Arg.getType()->isIntegerTy())
continue;
if (Arg.getType()->isPointerTy())
continue;
return false;
if (!isSupportedArgumentType(Arg.getType(), Subtarget))
return false;
}

MachineFunction &MF = MIRBuilder.getMF();
Expand Down Expand Up @@ -252,15 +287,11 @@ bool RISCVCallLowering::lowerCall(MachineIRBuilder &MIRBuilder,
const Function &F = MF.getFunction();
CallingConv::ID CC = F.getCallingConv();

// TODO: Support all argument types.
const RISCVSubtarget &Subtarget =
MIRBuilder.getMF().getSubtarget<RISCVSubtarget>();
for (auto &AInfo : Info.OrigArgs) {
if (AInfo.Ty->isIntegerTy())
continue;
if (AInfo.Ty->isPointerTy())
continue;
if (AInfo.Ty->isFloatingPointTy())
continue;
return false;
if (!isSupportedArgumentType(AInfo.Ty, Subtarget))
return false;
}

SmallVector<ArgInfo, 32> SplitArgInfos;
Expand Down Expand Up @@ -297,8 +328,7 @@ bool RISCVCallLowering::lowerCall(MachineIRBuilder &MIRBuilder,
if (Info.OrigRet.Ty->isVoidTy())
return true;

// TODO: Only integer, pointer and aggregate types are supported now.
if (!Info.OrigRet.Ty->isIntOrPtrTy() && !Info.OrigRet.Ty->isAggregateType())
if (!isSupportedReturnType(Info.OrigRet.Ty, Subtarget))
return false;

SmallVector<ArgInfo, 4> SplitRetInfos;
Expand Down