Skip to content

Revert [clang] Handle templated operators with reversed arguments and [STLExtras] Undo C++20 hack #69937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

usx95
Copy link
Contributor

@usx95 usx95 commented Oct 23, 2023

This breaks C++20 build of LLVM by clang 17 and earlier.
Next steps should be reduce error to a warning for https://godbolt.org/z/s99bvq4sG
b100ca6 or similar should be reapplied after the bug fix reached clang-18.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" llvm:adt labels Oct 23, 2023
@usx95 usx95 merged commit b997ff4 into llvm:main Oct 23, 2023
@nico
Copy link
Contributor

nico commented Oct 23, 2023

Looks like the revert broke tests: http://45.33.8.238/linux/121332/step_7.txt

Please take a look.

@usx95 usx95 self-assigned this Oct 23, 2023
@usx95
Copy link
Contributor Author

usx95 commented Oct 23, 2023

Apologies. I have reverted the missed tests in a876385
The build bots should be fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category llvm:adt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants