Skip to content

[libc++] <experimental/simd> Add assignment operator of simd reference #70020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

[libc++] <experimental/simd> Add assignment operator of simd reference #70020

merged 1 commit into from
Oct 26, 2023

Conversation

joy2myself
Copy link
Member

No description provided.

@joy2myself joy2myself requested a review from a team as a code owner October 24, 2023 09:47
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 24, 2023
philnik777
philnik777 reviewed Oct 24, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@joy2myself joy2myself force-pushed the split_simd branch 2 times, most recently from 094c608 to b513fc1 Compare October 25, 2023 06:59
philnik777
philnik777 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments addressed.

@joy2myself
Copy link
Member Author

Are these CI errors related? I didn't quite understand these error messages.

@philnik777
Copy link
Contributor

The FreeBSD failure looks like a fluke. I have no idea what AIX is complaining about, but that one looks like it's related. I'd just add an // XFAIL: LIBCXX-AIX-FIXME. CC @DanielMcIntosh @perry-ca

@philnik777 philnik777 merged commit cf0f6a1 into llvm:main Oct 26, 2023
vitalybuka added a commit that referenced this pull request Oct 27, 2023
@vitalybuka
[libc++] Disable test which timeouts on ARM with sanitizers
22c3d9d 
Introduced with cf0f6a1 (#70020).

https://lab.llvm.org/buildbot/#/builders/237/builds/5145
https://lab.llvm.org/buildbot/#/builders/236/builds/7004
https://lab.llvm.org/buildbot/#/builders/239/builds/4269

Sometimes it passes with Asan but it's extemly slow

```
Slowest Tests:
1388.61s: llvm-libc++-shared.cfg.in :: std/experimental/simd/simd.reference/reference_assignment.pass.cpp
309.42s:  llvm-libc++-shared.cfg.in :: std/containers/sequences/deque/deque.modifiers/insert_size_value.pass.cpp
```
@vitalybuka
Copy link
Collaborator

vitalybuka commented Oct 27, 2023 •
edited
Loading

I've disabled the test with sanitizers, it timeouts on ARM

Also I just checked x86_64, it also slowest test:

533.59s: llvm-libc++-shared.cfg.in :: std/experimental/simd/simd.reference/reference_assignment.pass.cpp
150.11s: llvm-libc++-shared.cfg.in :: std/containers/sequences/deque/deque.modifiers/insert_size_value.pass.cpp

@joy2myself Maybe you want to tweak the test to make it faster (< 50s ? ) and reenable sanitizers?

@philnik777
Copy link
Contributor

@vitalybuka What do you mean with "it timeouts on ARM"? Our CI ran just fine.

@vitalybuka
Copy link
Collaborator

@vitalybuka What do you mean with "it timeouts on ARM"? Our CI ran just fine.

https://lab.llvm.org/buildbot/#/builders/239/builds/4263/steps/11/logs/stdio

How long it takes to run that test?
Can you run them with LIT_OPTS="--time-tests -v" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philnik777 philnik777 philnik777 approved these changes

Assignees
No one assigned
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joy2myself @philnik777 @vitalybuka @llvmbot