Skip to content

[BOLT][AArch64] Fix ifuncs test header inclusion #71741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

rafaelauler
Copy link
Contributor

Summary: Do not include stdlib headers as these tests are built with -nostdlib. Tests outside of runtime folder also run cross-platforms, so an x86 machine wouldn't have access to the correct headers used in the aarch64 toolchain, even if it has an aarch64 compiler (clang itself).

Summary: Do not include stdlib headers as these tests are built with
-nostdlib. Tests outside of runtime folder also run cross-platforms,
so an x86 machine wouldn't have access to the correct headers used in
the aarch64 toolchain, even if it has an aarch64 compiler (clang
itself).
@yota9
Copy link
Member

yota9 commented Nov 9, 2023

Thanks @rafaelauler . Initially I've started to write runtime test and forgot to remove the lines. But saw it during preparing #71635 and fixed it, would be thankful for your approve so I won't have to rebase it. If there are some comments there fill free to submit your fix first.

@aaupov
Copy link
Contributor

aaupov commented Nov 9, 2023

Thanks @rafaelauler . Initially I've started to write runtime test and forgot to remove the lines. But saw it during preparing #71635 and fixed it, would be thankful for your approve so I won't have to rebase it. If there are some comments there fill free to submit your fix first.

Let's unblock testing first. It should be trivial to merge, no need to bundle up this fix. Thanks for addressing it though.

@rafaelauler rafaelauler merged commit 4c9f6d6 into llvm:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants