Skip to content

[NFC] Simplify the tiling implementation using cloning. #72178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 20, 2023
Merged

[NFC] Simplify the tiling implementation using cloning. #72178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
391c974
Clone operation before tiling them.
MaheshRavishankar Oct 19, 2023
7455bf1
Clone operation before tile and fuse
MaheshRavishankar Nov 13, 2023
cf5b8c9
Clone in Partial tile reduction.
MaheshRavishankar Oct 30, 2023
f94d33c
Fix tile+fuse+yield
MaheshRavishankar Nov 13, 2023
c282a94
NFC: code-reorganzation and deletion.
MaheshRavishankar Nov 13, 2023
5839352
Address first rounds of comments.
MaheshRavishankar Nov 15, 2023
78c0cfe
Guard for cases where loops are empty, and use zip::equal
Abhishek-Varma Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions mlir/include/mlir/Dialect/SCF/Transforms/TileUsingInterface.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ FailureOr<SCFTilingResult> tileUsingSCFForOp(RewriterBase &rewriter,
TilingInterface op,
const SCFTilingOptions &options);

/// Method to tile an op that implements the `TilingInterface` using
/// `scf.forall`.
FailureOr<SCFTilingResult>
tileUsingSCFForallOp(RewriterBase &rewriter, TilingInterface op,
const SCFTilingOptions &options);

/// Options used to control tile + fuse.
struct SCFTileAndFuseOptions {
/// The tiling options used to control the tiling of the consumer.
Expand All @@ -93,12 +99,6 @@ struct SCFTileAndFuseOptions {
}
};

/// Method to tile an op that implements the `TilingInterface` using
/// `scf.forall`.
FailureOr<SCFTilingResult>
tileUsingSCFForallOp(RewriterBase &rewriter, TilingInterface op,
const SCFTilingOptions &options);

/// Fuse the producer of the source of `candidateSliceOp` by computing the
/// required slice of the producer in-place. Note that the method
/// replaces the uses of `candidateSliceOp` with the tiled and fused producer
Expand Down
Loading