Skip to content

[libclang/python] Fix some minor typos #74292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

linux4life798
Copy link
Contributor

@linux4life798 linux4life798 commented Dec 4, 2023

These patches do not change the functionality of the library. They simply correct comments and documentation.

  • Add a missing space in a the FixIt class comment
  • Fix an llvm-project path in the README.txt

Update the path to the python binding dir in the llvm-project src tree.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Dec 4, 2023
@llvmbot
Copy link
Member

llvmbot commented Dec 4, 2023

@llvm/pr-subscribers-clang

Author: Craig Hesling (linux4life798)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/74292.diff

2 Files Affected:

  • (modified) clang/bindings/python/README.txt (+1-1)
  • (modified) clang/bindings/python/clang/cindex.py (+1-1)
diff --git a/clang/bindings/python/README.txt b/clang/bindings/python/README.txt
index b0f0142a56f11..44c715e5de56f 100644
--- a/clang/bindings/python/README.txt
+++ b/clang/bindings/python/README.txt
@@ -8,7 +8,7 @@ You may need to set CLANG_LIBRARY_PATH so that the Clang library can be
 found. The unit tests are designed to be run with any standard test
 runner. For example:
 --
-$ env PYTHONPATH=$(echo ~/llvm/tools/clang/bindings/python/) \
+$ env PYTHONPATH=$(echo ~/llvm/clang/bindings/python/) \
       CLANG_LIBRARY_PATH=$(llvm-config --libdir) \
   python -m unittest discover -v
 tests.cindex.test_index.test_create ... ok
diff --git a/clang/bindings/python/clang/cindex.py b/clang/bindings/python/clang/cindex.py
index 6a16f3a9ef6e9..d780ee353a133 100644
--- a/clang/bindings/python/clang/cindex.py
+++ b/clang/bindings/python/clang/cindex.py
@@ -535,7 +535,7 @@ def from_param(self):
 class FixIt(object):
     """
     A FixIt represents a transformation to be applied to the source to
-    "fix-it". The fix-it shouldbe applied by replacing the given source range
+    "fix-it". The fix-it should be applied by replacing the given source range
     with the given value.
     """
 

@jyknight jyknight merged commit 29e043c into llvm:main Dec 14, 2023
@linux4life798 linux4life798 deleted the fix-minor-typos branch December 14, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants