Skip to content

[builtins] Avoid using long double in FreeBSD standalone environment #76175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[builtins] Avoid using long double in FreeBSD standalone environment #76175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions compiler-rt/lib/builtins/int_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ typedef union {
udwords u;
double f;
} double_bits;
#endif

typedef struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this struct not needed outside of the no-fp case?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, uqwords is only used in the subsequent declarations of the xf_bits union (for 80 bit long doubles) and the tf_bits union (for 128 bit quads). (This is not the case for the earlier udwords, btw)

#if _YUGA_LITTLE_ENDIAN
Expand Down Expand Up @@ -220,7 +219,6 @@ typedef union {
#define CRT_HAS_TF_MODE
#endif

#if CRT_HAS_FLOATING_POINT
#if __STDC_VERSION__ >= 199901L
typedef float _Complex Fcomplex;
typedef double _Complex Dcomplex;
Expand Down Expand Up @@ -270,5 +268,5 @@ typedef struct {
#define COMPLEXTF_IMAGINARY(x) (x).imaginary
#endif

#endif
#endif // CRT_HAS_FLOATING_POINT
#endif // INT_TYPES_H