-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libc] Add memcmp / bcmp fuzzers #77741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b425a07
[libc] Add memcmp / bcmp fuzzers
gchatelet bf14015
remove address sanitizer addition from this patch
gchatelet dbaf123
Add documentation about odd fuzzed data size
gchatelet acecda9
print count before buffers
gchatelet 27bc3fa
Add actual result as well as reference result
gchatelet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
//===-- bcmp_fuzz.cpp ---------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
/// | ||
/// Fuzzing test for llvm-libc bcmp implementation. | ||
/// | ||
//===----------------------------------------------------------------------===// | ||
#include "src/string/bcmp.h" | ||
#include <stddef.h> | ||
#include <stdint.h> | ||
#include <stdio.h> | ||
#include <string.h> | ||
|
||
static int reference_bcmp(const void *pa, const void *pb, size_t count) | ||
__attribute__((no_builtin)) { | ||
const auto *a = reinterpret_cast<const unsigned char *>(pa); | ||
const auto *b = reinterpret_cast<const unsigned char *>(pb); | ||
for (size_t i = 0; i < count; ++i, ++a, ++b) | ||
if (*a != *b) | ||
return 1; | ||
return 0; | ||
} | ||
|
||
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | ||
const auto normalize = [](int value) -> int { | ||
if (value == 0) | ||
return 0; | ||
return 1; | ||
}; | ||
const auto count = size / 2; | ||
gchatelet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const char *a = reinterpret_cast<const char *>(data); | ||
const char *b = reinterpret_cast<const char *>(data) + count; | ||
const int actual = LIBC_NAMESPACE::bcmp(a, b, count); | ||
const int reference = reference_bcmp(a, b, count); | ||
if (normalize(actual) == normalize(reference)) | ||
return 0; | ||
const auto print = [](const char *msg, const char *buffer, size_t size) { | ||
printf("%s\"", msg); | ||
for (size_t i = 0; i < size; ++i) | ||
printf("\\x%02x", (uint8_t)buffer[i]); | ||
printf("\"\n"); | ||
}; | ||
print("a : ", a, count); | ||
print("b : ", b, count); | ||
printf("count : %zu\n", count); | ||
gchatelet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
printf("result: %d\n", reference); | ||
__builtin_trap(); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
//===-- memcmp_fuzz.cpp ---------------------------------------------------===// | ||
// | ||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
/// | ||
/// Fuzzing test for llvm-libc memcmp implementation. | ||
/// | ||
//===----------------------------------------------------------------------===// | ||
#include "src/string/memcmp.h" | ||
#include <stddef.h> | ||
#include <stdint.h> | ||
#include <stdio.h> | ||
#include <string.h> | ||
|
||
static int reference_memcmp(const void *pa, const void *pb, size_t count) | ||
__attribute__((no_builtin)) { | ||
const auto *a = reinterpret_cast<const unsigned char *>(pa); | ||
const auto *b = reinterpret_cast<const unsigned char *>(pb); | ||
for (size_t i = 0; i < count; ++i, ++a, ++b) { | ||
if (*a < *b) | ||
return -1; | ||
else if (*a > *b) | ||
return 1; | ||
} | ||
return 0; | ||
} | ||
|
||
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { | ||
const auto sign = [](int value) -> int { | ||
if (value < 0) | ||
return -1; | ||
if (value > 0) | ||
return 1; | ||
return 0; | ||
}; | ||
const auto count = size / 2; | ||
gchatelet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
const char *a = reinterpret_cast<const char *>(data); | ||
const char *b = reinterpret_cast<const char *>(data) + count; | ||
const int actual = LIBC_NAMESPACE::memcmp(a, b, count); | ||
const int reference = reference_memcmp(a, b, count); | ||
if (sign(actual) == sign(reference)) | ||
return 0; | ||
const auto print = [](const char *msg, const char *buffer, size_t size) { | ||
printf("%s\"", msg); | ||
for (size_t i = 0; i < size; ++i) | ||
printf("\\x%02x", (uint8_t)buffer[i]); | ||
printf("\"\n"); | ||
}; | ||
print("a : ", a, count); | ||
print("b : ", b, count); | ||
printf("count : %zu\n", count); | ||
printf("result: %d\n", reference); | ||
gchatelet marked this conversation as resolved.
Show resolved
Hide resolved
|
||
__builtin_trap(); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://llvm.org/docs/LibFuzzer.html#fuzzer-usage :
In most cases you may want to combine libFuzzer with AddressSanitizer (ASAN), UndefinedBehaviorSanitizer (UBSAN), or both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that in a separate patch