[builtins] Support QUAD with native long double #77981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
perry-ca
changed the title
|
@arichardson any idea why the build failed? It appears to be in some tests for dlopen(). |
|
I'll try testing this for various architectures tomorrow and if that works I'll go ahead and merge it. |
|
I am getting some errors when cross-building for PPC64, will do some digging to see how the ifdefs need to be adjusted. |
|
Thanks for the update
From: Alexander Richardson ***@***.***>
Sent: Tuesday, January 16, 2024 2:35 PM
To: llvm/llvm-project ***@***.***>
Cc: Sean Perry ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [llvm/llvm-project] [builtins] Support QUAD with native long double (PR #77981)
I am getting some errors when cross-building for PPC64, will do some digging to see how the ifdefs need to be adjusted. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
Report Suspicious <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/PjiDSg!2U-qSTa06VIRMu4YcIkOZYJv87-YdAlWKJZAkdb8L-gnGW_ui7Pp0b5Yv70fJ1Bccsd7hQG_1LcVxoDvhJzfUxeRIQve7bs1P2zh$>
ZjQcmQRYFpfptBannerEnd
I am getting some errors when cross-building for PPC64, will do some digging to see how the ifdefs need to be adjusted.
—
Reply to this email directly, view it on GitHub<#77981 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJQT7WAKBKEBDFNHBX4D7L3YO3I53AVCNFSM6AAAAABBYWHEWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJUGM4DQNJWGU>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
@arichardson has addressed the build issues in #82208. This PR is superseded by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo #77554 to solve build issue found in #77880.