[AArch64][compiler-rt] Avoid use of libc header in sme-libc-routines #79454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `#include <stdlib.h>` introduces a libc dependency. In many build environments such a file can be found under e.g. /usr/include, but this does not correspond to the libc in use, which may not be available until after the builtins have been built. So far as I understand, it's not valid to have a dependency on libc from builtins; there are a handful of such includes in builtins, but they are protected by ifdefs. Instead, use <stddef.h> which is provided by the compiler's resource headers and so should always be available.
peterwaller-arm
requested review from
MaskRay,
dtemirbulatov,
sdesmalen-arm and
david-arm
|
LGTM. Thanks. |
dtemirbulatov
approved these changes
Jan 25, 2024
MaskRay
approved these changes
Jan 26, 2024
sdesmalen-arm
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
#include <stdlib.h>introduces a libc dependency. In many build environments such a file can be found under e.g. /usr/include, but this does not necessarily correspond to the libc in use, which may not be available until after the builtins have been built.So far as I understand, it's not valid to have a dependency on libc from builtins; there are a handful of such includes in builtins, but they are protected by ifdefs.
Instead, use <stddef.h>, which provides
size_tand is provided by the compiler's resource headers and so should always be available.