[libc++][ci] Update upload-artifact@v3 and hashpin the version #79854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upload-artifact@v3 action is using Node 16, which is reaching EOL. As a result, we are getting warnings prompting us to move our jobs over to the latest version of upload-artifact.
ldionne
added
libc++
|
@llvm/pr-subscribers-libcxx @llvm/pr-subscribers-github-workflow Author: Louis Dionne (ldionne) ChangesThe upload-artifact@v3 action is using Node 16, which is reaching EOL. As a result, we are getting warnings prompting us to move our jobs over to the latest version of upload-artifact. Full diff: https://github.com/llvm/llvm-project/pull/79854.diff 1 Files Affected:
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 9579c05f1c5b1af..ba5a63eac8bf8b4 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -75,7 +75,7 @@ jobs:
CC: ${{ matrix.cc }}
CXX: ${{ matrix.cxx }}
ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }}
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: always()
with:
name: ${{ matrix.config }}-${{ matrix.cxx }}-results
@@ -124,7 +124,7 @@ jobs:
CC: ${{ matrix.cc }}
CXX: ${{ matrix.cxx }}
ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }}
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: always() # Upload artifacts even if the build or test suite fails
with:
name: ${{ matrix.config }}-results
@@ -189,7 +189,7 @@ jobs:
CC: clang-18
CXX: clang++-18
ENABLE_CLANG_TIDY: "OFF"
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
if: always()
with:
name: ${{ matrix.config }}-results
|
tstellar
reviewed
Jan 29, 2024
| @@ -75,7 +75,7 @@ jobs: | |||
| CC: ${{ matrix.cc }} | |||
| CXX: ${{ matrix.cxx }} | |||
| ENABLE_CLANG_TIDY: ${{ matrix.clang_tidy }} | |||
| - uses: actions/upload-artifact@v3 | |||
| - uses: actions/upload-artifact@v4 | |||
There was a problem hiding this comment.
We've been advised to use the full git hash rather than tags when referencing these actions. See f3524e9
ldionne
changed the title
tstellar
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upload-artifact@v3 action is using Node 16, which is reaching EOL. As a result, we are getting warnings prompting us to move our jobs over to the latest version of upload-artifact.