Skip to content

[libc++][doc] Updates LWG3346 status. #80536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

mordante
Copy link
Member

@mordante mordante commented Feb 3, 2024

The issue addresses an obvious wording issue. Implementing the constructors as specified in the synposis, as libc++ did, already implements the fixed behaviour.

Updates:

  • LWG3346 pair and tuple copy and move constructor have backwards specification

The issue addresses an obvious wording issue. Implementing the constructors
as specified in the synposis, as libc++ did, already implements the fixed
behaviour.

Updates:
- LWG3346 pair and tuple copy and move constructor have backwards specification
@mordante mordante requested a review from a team as a code owner February 3, 2024 10:20
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Feb 3, 2024
@llvmbot
Copy link
Member

llvmbot commented Feb 3, 2024

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

The issue addresses an obvious wording issue. Implementing the constructors as specified in the synposis, as libc++ did, already implements the fixed behaviour.

Updates:

  • LWG3346 pair and tuple copy and move constructor have backwards specification

Full diff: https://github.com/llvm/llvm-project/pull/80536.diff

1 Files Affected:

  • (modified) libcxx/docs/Status/Cxx20Issues.csv (+1-1)
diff --git a/libcxx/docs/Status/Cxx20Issues.csv b/libcxx/docs/Status/Cxx20Issues.csv
index 964c21df97e21..316127f44e0dd 100644
--- a/libcxx/docs/Status/Cxx20Issues.csv
+++ b/libcxx/docs/Status/Cxx20Issues.csv
@@ -258,7 +258,7 @@
 "`3335 <https://wg21.link/LWG3335>`__","Resolve C++20 NB comments US 273 and GB 274","Prague","|Complete|","15.0","|ranges|"
 "`3338 <https://wg21.link/LWG3338>`__","Rename ``default_constructible``\  to ``default_initializable``\ ","Prague","|Complete|","13.0"
 "`3340 <https://wg21.link/LWG3340>`__","Formatting functions should throw on argument/format string mismatch in |sect|\ [format.functions]","Prague","|Complete|","14.0","|format|"
-"`3346 <https://wg21.link/LWG3346>`__","``pair``\  and ``tuple``\  copy and move constructor have backwards specification","Prague","",""
+"`3346 <https://wg21.link/LWG3346>`__","``pair``\  and ``tuple``\  copy and move constructor have backwards specification","Prague","|Nothing To Do|",""
 "`3347 <https://wg21.link/LWG3347>`__","``std::pair<T, U>``\  now requires ``T``\  and ``U``\  to be less-than-comparable","Prague","|Complete|","17.0"
 "`3348 <https://wg21.link/LWG3348>`__","``__cpp_lib_unwrap_ref``\  in wrong header","Prague","|Complete|","12.0"
 "`3349 <https://wg21.link/LWG3349>`__","Missing ``__cpp_lib_constexpr_complex``\  for P0415R1","Prague","|Complete|","16.0"

@ldionne ldionne merged commit 04f99be into llvm:main Feb 5, 2024
agozillon pushed a commit to agozillon/llvm-project that referenced this pull request Feb 5, 2024
The issue addresses an obvious wording issue. Implementing the
constructors as specified in the synposis, as libc++ did, already
implements the fixed behaviour.

Updates:
- LWG3346 pair and tuple copy and move constructor have backwards
specification
@mordante mordante deleted the review/update_lwg3346_status branch February 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants