[NFC][clang][Driver] Specify options for <arg> with -save-temps=<arg> #80921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Jacob Lambert (lamb-j) ChangesFull diff: https://github.com/llvm/llvm-project/pull/80921.diff 1 Files Affected:
diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td
index 4b232b8aab722..6b13530799e10 100644
--- a/clang/include/clang/Driver/Options.td
+++ b/clang/include/clang/Driver/Options.td
@@ -5392,7 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group<m_Group>,
MarshallingInfoFlag<LangOpts<"RegCall4">>;
def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>,
Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
- HelpText<"Save intermediate compilation results.">;
+ HelpText<"Save intermediate compilation results. The <arg> option can be set "
+ "to cwd for current working directory, or obj which will save temporary "
+ "files in the same directory as the final output file">;
def save_temps : Flag<["-", "--"], "save-temps">, Flags<[NoXarchOption]>,
Visibility<[ClangOption, FlangOption, FC1Option]>,
Alias<save_temps_EQ>, AliasArgs<["cwd"]>,
|
MaskRay
approved these changes
Feb 7, 2024
| @@ -5392,7 +5392,9 @@ def regcall4 : Flag<["-"], "regcall4">, Group<m_Group>, | |||
| MarshallingInfoFlag<LangOpts<"RegCall4">>; | |||
| def save_temps_EQ : Joined<["-", "--"], "save-temps=">, Flags<[NoXarchOption]>, | |||
| Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>, | |||
| HelpText<"Save intermediate compilation results.">; | |||
| HelpText<"Save intermediate compilation results. The <arg> option can be set " | |||
There was a problem hiding this comment.
<arg> is an argument, not an option, but it is unnecessary to mention it is an argument.
<arg> can be set to 'cwd' for ..., or 'obj' ...
There was a problem hiding this comment.
The committed version does not contain single quotes. I'll add them.
There was a problem hiding this comment.
Ah good catch, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.