[builtins] Disable COMPILER_RT_CRT_USE_EH_FRAME_REGISTRY by default #83201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
petrhosek
approved these changes
Feb 27, 2024
Created using spr 1.3.4
MaskRay
deleted the
users/MaskRay/spr/builtins-disable-compiler_rt_crt_use_eh_frame_registry-by-default
branch
|
Hey, it looks like this breaks LLDB's test suite on Fuchsia's AArch64 builders: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-arm64/b8754880571862677073/overview Reverting this change from the blamelist succeeds, and it's the only likely candidate change with that property. |
|
Can we revert this change and then dig into the reason why these tests started failing? Our builders have been broken for an entire week and I'd like to avoid leaving them broken over the weekend. |
This was referenced Mar 8, 2024
mysterymath
added a commit
that referenced
this pull request
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of GCC's Linux targets have a link spec
%{!static|static-pie:--eh-frame-hdr}that doesn't pass --eh-frame-hdrfor
-staticlinks.-staticlinks are supposed to utilize__register_frame_info(called bycrtbeginT.o, not by crtbegin.o orcrtbeginS.o) as a replacement.
compiler-rt crtbegin (not used with GCC) has some ehframe code, which is
not utilized because Clang driver unconditionally passes --eh-frame-hdr
for Linux targets, even for -static. In addition, LLVM libunwind
implements
__register_frame_infoas an empty stub.Furthermore, in a non-static link, the
__register_frame_inforeferences can cause an undesired weak dynamic symbol.
For now, just disable the config by default.