[clang][StaticAnalyzer] fix function evalCall() typo in CheckerDocumentation #83677
Conversation
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Exile (mzyKi) Changes
Full diff: https://github.com/llvm/llvm-project/pull/83677.diff 1 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp b/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
index 3e5e2b9139149d..0ca0c487b64550 100644
--- a/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
@@ -226,7 +226,7 @@ class CheckerDocumentation : public Checker< check::PreStmt<ReturnStmt>,
/// first one wins.
///
/// eval::Call
- bool evalCall(const CallExpr *CE, CheckerContext &C) const { return true; }
+ bool evalCall(const CallEvent &Call, CheckerContext &C) const { return true; }
/// Handles assumptions on symbolic values.
///
|
|
@llvm/pr-subscribers-clang-static-analyzer-1 Author: Exile (mzyKi) Changes
Full diff: https://github.com/llvm/llvm-project/pull/83677.diff 1 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp b/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
index 3e5e2b9139149d..0ca0c487b64550 100644
--- a/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp
@@ -226,7 +226,7 @@ class CheckerDocumentation : public Checker< check::PreStmt<ReturnStmt>,
/// first one wins.
///
/// eval::Call
- bool evalCall(const CallExpr *CE, CheckerContext &C) const { return true; }
+ bool evalCall(const CallEvent &Call, CheckerContext &C) const { return true; }
/// Handles assumptions on symbolic values.
///
|
|
Makes sense, but how did it build before the fix? |
|
… checker callbacks (#83973) In PR #83677 I was surprised to see that outdated checker callback signatures are a problem. It turns out, we need the `registerChecker...` function to invoke the `Mgr.registerChecker<>()` which would instantiate the `_register` calls, that would take the address of the defined checker callbacks. Consequently, if the expected signatures mismatch, it won't compile from now on, so we have static guarantee that this issue never pops up again. Given we need the `register` call, at this point we could just hook this checker into the `debug` package and make it never registered. It shouldn't hurt anyone :)
bool evalCall(const CallEvent &Call, CheckerContext &C)is corret form.