Skip to content

[lldb][test][FreeBSD] Remove corefile test xfails #84022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

DavidSpickett
Copy link
Collaborator

Fixes #48759

As stated on the issue this was fixed by a change in FreeBSD 13, and I've confirmed that it passes on 14 as well.

Fixes llvm#48759

As stated on the issue this was fixed by a change in FreeBSD 13,
and I've confirmed that it passes on 14 as well.
@DavidSpickett DavidSpickett requested a review from emaste March 5, 2024 14:43
@llvmbot llvmbot added the lldb label Mar 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 5, 2024

@llvm/pr-subscribers-lldb

Author: David Spickett (DavidSpickett)

Changes

Fixes #48759

As stated on the issue this was fixed by a change in FreeBSD 13, and I've confirmed that it passes on 14 as well.


Full diff: https://github.com/llvm/llvm-project/pull/84022.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py (+2-6)
diff --git a/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py b/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
index 7ec5e0d7c8309b..8ec0cbdd0fdd1f 100644
--- a/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
+++ b/lldb/test/API/functionalities/postmortem/elf-core/TestLinuxCore.py
@@ -292,9 +292,7 @@ def test_aarch64_pac(self):
         self.dbg.DeleteTarget(target)
 
     @skipIfLLVMTargetMissing("AArch64")
-    @expectedFailureAll(
-        archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49415"
-    )
+    # This test fails on FreeBSD 12 and earlier, see llvm.org/pr49415 for details.
     def test_aarch64_regs(self):
         # check 64 bit ARM core files
         target = self.dbg.CreateTarget(None)
@@ -377,9 +375,7 @@ def test_aarch64_regs(self):
         self.expect("register read --all")
 
     @skipIfLLVMTargetMissing("AArch64")
-    @expectedFailureAll(
-        archs=["aarch64"], oslist=["freebsd"], bugnumber="llvm.org/pr49415"
-    )
+    # This test fails on FreeBSD 12 and earlier, see llvm.org/pr49415 for details.
     def test_aarch64_sve_regs_fpsimd(self):
         # check 64 bit ARM core files
         target = self.dbg.CreateTarget(None)

@DavidSpickett DavidSpickett changed the title [lldb][FreeBSD] Remove corefile test xfails [lldb][test][FreeBSD] Remove corefile test xfails Mar 6, 2024
@DavidSpickett DavidSpickett merged commit a015f01 into llvm:main May 2, 2024
@DavidSpickett DavidSpickett deleted the bsd-core branch May 2, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestLinuxCore: two aarch64 reg test cases fail on FreeBSD/aarch64
3 participants