Skip to content

[lldb][test][FreeBSD] Narrow vectorcall xfail to x86 platforms #84024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024

Conversation

DavidSpickett
Copy link
Collaborator

@DavidSpickett DavidSpickett commented Mar 5, 2024

This relates to #56084.

vectorcall only works on x86 https://clang.llvm.org/docs/AttributeReference.html#vectorcall so elsewhere it fails to compile. Which is expected on AArch64 for example so is treated as a pass.

vectorcall only works on x86 https://clang.llvm.org/docs/AttributeReference.html#vectorcall
so elsewhere it fails to compile. Which is expected on AArch64 for
example so is treated as a pass.
@DavidSpickett DavidSpickett requested a review from emaste March 5, 2024 14:59
@llvmbot llvmbot added the lldb label Mar 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Mar 5, 2024

@llvm/pr-subscribers-lldb

Author: David Spickett (DavidSpickett)

Changes

vectorcall only works on x86 https://clang.llvm.org/docs/AttributeReference.html#vectorcall so elsewhere it fails to compile. Which is expected on AArch64 for example so is treated as a pass.


Full diff: https://github.com/llvm/llvm-project/pull/84024.diff

1 Files Affected:

  • (modified) lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py (+3)
diff --git a/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py b/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py
index 9483dfcd040186..0304482e899b82 100644
--- a/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py
+++ b/lldb/test/API/lang/c/calling-conventions/TestCCallingConventions.py
@@ -62,7 +62,10 @@ def test_stdcall(self):
             return
         self.expect_expr("func(1, 2, 3, 4)", result_type="int", result_value="10")
 
+    # Fails on x86, passes elsewhere because clang doesn't support vectorcall on
+    # any other architectures.
     @expectedFailureAll(
+        triple=re.compile("^(x86|i386)"),
         oslist=["freebsd"], bugnumber="github.com/llvm/llvm-project/issues/56084"
     )
     def test_vectorcall(self):

@DavidSpickett DavidSpickett merged commit 528b512 into llvm:main May 2, 2024
@DavidSpickett DavidSpickett deleted the bsd-callingconv branch May 2, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants