-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[clang][CodeGen] Omit pre-opt link when post-opt is link requested #85672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aff1a76
[clang][CodeGen] Omit pre-opt link when post-opt link requested
lamb-j 9a6757c
fix option name
lamb-j e2b6956
Fix analyses return and typo
lamb-j 2238bf9
Update comment
lamb-j 064744a
Remove ReloadModules() declaration/definition
lamb-j 65cdd73
Merge branch 'main' into omit-first-link
lamb-j 4cf9233
Merge branch 'llvm:main' into omit-first-link
lamb-j 2dc99c2
Switch to a regular Clang option, and add a LIT test
lamb-j 7f4c296
Switch lit test from Driver to CodeGen
lamb-j File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
// REQUIRES: amdgpu-registered-target | ||
|
||
// Test that -mlink-bitcode-postopt correctly enables LinkInModulesPass | ||
|
||
// RUN: %clang_cc1 -triple amdgcn-- -emit-llvm-bc -o /dev/null \ | ||
// RUN: -mllvm -print-pipeline-passes \ | ||
// RUN: %s 2>&1 | FileCheck --check-prefixes=DEFAULT %s | ||
|
||
// DEFAULT-NOT: LinkInModulesPass | ||
|
||
// RUN: %clang_cc1 -triple amdgcn-- -emit-llvm-bc -o /dev/null \ | ||
// RUN: -mllvm -print-pipeline-passes \ | ||
// RUN: -mlink-builtin-bitcode-postopt \ | ||
// RUN: %s 2>&1 | FileCheck --check-prefixes=OPTION-POSITIVE %s | ||
|
||
// OPTION-POSITIVE: LinkInModulesPass | ||
|
||
// RUN: %clang_cc1 -triple amdgcn-- -emit-llvm-bc -o /dev/null \ | ||
// RUN: -mllvm -print-pipeline-passes \ | ||
// RUN: -mno-link-builtin-bitcode-postopt \ | ||
// RUN: %s 2>&1 | FileCheck --check-prefixes=OPTION-NEGATIVE %s | ||
|
||
// OPTION-NEGATIVE-NOT: LinkInModulesPass | ||
|
||
// RUN: %clang_cc1 -triple amdgcn-- -emit-llvm-bc -o /dev/null \ | ||
// RUN: -mllvm -print-pipeline-passes \ | ||
// RUN: -mlink-builtin-bitcode-postopt \ | ||
// RUN: -mno-link-builtin-bitcode-postopt \ | ||
// RUN: %s 2>&1 | FileCheck --check-prefixes=OPTION-POSITIVE-NEGATIVE %s | ||
|
||
// OPTION-POSITIVE-NEGATIVE-NOT: LinkInModulesPass |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.