[Libomptarget] Move API implementations into GenericPluginTy #86683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
requested review from
carlobertolli,
dhruvachak,
estewart08,
jdoerfert,
JonChesterfield,
ronlieb,
saiislam and
shiltian
jhuber6
force-pushed
the
ReworkAPIInterface
branch
4 times, most recently
from
af25ad7 to
5b51b25
Compare
Summary: The plan is to remove the entire plugin interface and simply use the `GenericPluginTy` inside of `libomptarget` by statically linking against it. This means that inside of `libomptarget` we will simply do `Plugin.data_alloc` without the dynamically loaded interface. To reduce the amount of code required, this patch simply moves all of the RTL implementation functions inside of the Generic device. Now the `__tgt_rtl_` interface is simply a shallow wrapper that will soon go away. There is some redundancy here, this will be improved later. For now what is important is minimizing the changes to the API.
jhuber6
force-pushed
the
ReworkAPIInterface
branch
from
5b51b25 to
976b442
Compare
ronlieb
approved these changes
Mar 27, 2024
jdoerfert
reviewed
Mar 27, 2024
| /// to the async versions right away with a NULL AsyncInfoPtr. | ||
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif |
There was a problem hiding this comment.
This was already here, but will all be deleted soon enough.
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Mar 28, 2024
brings in [Libomptarget] Move API implementations into GenericPluginTy (llvm#86683) Change-Id: Id91192d0298a78e7fe80b824f4f28fb02186cd79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The plan is to remove the entire plugin interface and simply use the
GenericPluginTyinside oflibomptargetby statically linking againstit. This means that inside of
libomptargetwe will simply doPlugin.data_allocwithout the dynamically loaded interface. To reducethe amount of code required, this patch simply moves all of the RTL
implementation functions inside of the Generic device. Now the
__tgt_rtl_interface is simply a shallow wrapper that will soon goaway. There is some redundancy here, this will be improved later. For
now what is important is minimizing the changes to the API.