Skip to content

Include cmath to fix build error on mac os 10.14 #88665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Conversation

Zentrik
Copy link
Contributor

@Zentrik Zentrik commented Apr 14, 2024

This fixes #88664.

@llvmbot
Copy link
Member

llvmbot commented Apr 14, 2024

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: None (Zentrik)

Changes

This should fix #88664.


Full diff: https://github.com/llvm/llvm-project/pull/88665.diff

1 Files Affected:

  • (modified) clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp (+1)
diff --git a/clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp b/clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp
index b299afd540b9a3..45a8f973486147 100644
--- a/clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/UseStdNumbersCheck.cpp
@@ -35,6 +35,7 @@
 #include <string>
 #include <tuple>
 #include <utility>
+#include <cmath>
 
 namespace {
 using namespace clang::ast_matchers;

Copy link

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

Copy link

github-actions bot commented Apr 14, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@PiotrZSL PiotrZSL merged commit a5f5417 into llvm:main Apr 14, 2024
bazuzi pushed a commit to bazuzi/llvm-project that referenced this pull request Apr 15, 2024
Zentrik added a commit to Zentrik/llvm-project that referenced this pull request Apr 16, 2024
giordano pushed a commit to JuliaLang/llvm-project that referenced this pull request May 2, 2024
giordano pushed a commit to JuliaLang/llvm-project that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on mac os 10.14 due to not including cmath
3 participants