[libc][test] adds LINK_LIBRARIES pthread to pthreads test cmake

[Flandini]

Fixes #89261.

cc @nickdesaulniers

fixes this for me. seems like others might not have the same issue, so lmk if i'm just building this wrong.

[llvmbot]

@llvm/pr-subscribers-libc

Author: Michael Flanders (Flandini)

Changes

Fixes #89261.

cc @nickdesaulniers

fixes this for me. seems like others might not have the same issue, so lmk if i'm just building this wrong.

---

Full diff: https://github.com/llvm/llvm-project/pull/89262.diff

1 Files Affected:

• (modified) libc/test/src/pthread/CMakeLists.txt (+6)

diff --git a/libc/test/src/pthread/CMakeLists.txt b/libc/test/src/pthread/CMakeLists.txt
index 51954a5babd2c5..53a7a14f8d558c 100644
--- a/libc/test/src/pthread/CMakeLists.txt
+++ b/libc/test/src/pthread/CMakeLists.txt
@@ -19,6 +19,8 @@ add_libc_unittest(
     libc.src.pthread.pthread_attr_setguardsize
     libc.src.pthread.pthread_attr_setstacksize
     libc.src.pthread.pthread_attr_setstack
+  LINK_LIBRARIES
+    -lpthread
 )
 
 add_libc_unittest(
@@ -38,6 +40,8 @@ add_libc_unittest(
     libc.src.pthread.pthread_mutexattr_setpshared
     libc.src.pthread.pthread_mutexattr_setrobust
     libc.src.pthread.pthread_mutexattr_settype
+  LINK_LIBRARIES
+    -pthread
 )
 
 add_libc_unittest(
@@ -56,4 +60,6 @@ add_libc_unittest(
     libc.src.pthread.pthread_condattr_init
     libc.src.pthread.pthread_condattr_setclock
     libc.src.pthread.pthread_condattr_setpshared
+  LINK_LIBRARIES
+    -pthread
   )

[michaelrj-google]

This shouldn't be necessary, since -lpthread just tells the compiler to link in the system's pthread library. If this test is actually using our library it shouldn't have any effect since we don't build a separate libpthread. Maybe try cleaning your build directory (with rm -r build/projects/libc) and rebuilding?

[nickdesaulniers]

Do you have eefee38 on your branch?

[nickdesaulniers]

Please let us know if #89308 helps resolve this issue for you? Sorry for my mistake creating a problem!

[Flandini]

Please let us know if #89308 helps resolve this issue for you? Sorry for my mistake creating a problem!

Yup, that fixed it, thanks!