Skip to content

[InstCombine] Do not request non-splat vector support in code reviews (NFC) #90709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2024
Merged

[InstCombine] Do not request non-splat vector support in code reviews (NFC) #90709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb77852
[InstCombine] Do not request non-splat vector support in code reviews…
nikic May 1, 2024
1a04be3
Add "new"
nikic May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions llvm/docs/InstCombineContributorGuide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,3 +554,11 @@ guidelines.
use of ValueTracking queries. Whether this makes sense depends on the case,
but it's usually a good idea to only handle the constant pattern first, and
then generalize later if it seems useful.

## Guidelines for reviewers

* Do not ask new contributors to implement non-splat vector support in code
reviews. If you think non-splat vector support for a fold is both
worthwhile and policy-compliant (that is, the handling would not result in
any appreciable increase in code complexity), implement it yourself in a
follow-up patch.
Loading