-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[Clang] -fseparate-named-sections option #91028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
78193f6
[Clang] -fseparate-named-sections option
petrhosek ff14d32
More tests and release notes
petrhosek cafbf6f
Remove unused option
petrhosek 5b7aaa6
Address review feedback
petrhosek 1ce6653
Address review feedback
petrhosek 63a8296
Merge remote-tracking branch 'origin/main' into separate-named-sections
petrhosek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// REQUIRES: x86-registered-target | ||
|
||
// RUN: %clang_cc1 -triple x86_64-pc-linux -S -o - < %s | FileCheck %s | ||
// RUN: %clang_cc1 -triple x86_64-pc-linux -S -fseparate-named-sections -o - < %s | FileCheck %s --check-prefix=SEPARATE | ||
|
||
__attribute__((section("custom_text"))) void f(void) {} | ||
__attribute__((section("custom_text"))) void g(void) {} | ||
|
||
// CHECK: .section custom_text,"ax",@progbits{{$}} | ||
// CHECK: f: | ||
// CHECK: g: | ||
|
||
// SEPARATE: .section custom_text,"ax",@progbits,unique,1{{$}} | ||
// SEPARATE: f: | ||
// SEPARATE: .section custom_text,"ax",@progbits,unique,2{{$}} | ||
// SEPARATE: g: | ||
|
||
__attribute__((section("custom_data"))) int i = 0; | ||
__attribute__((section("custom_data"))) int j = 0; | ||
|
||
// CHECK: .section custom_data,"aw",@progbits{{$}} | ||
// CHECK: i: | ||
// CHECK: j: | ||
|
||
// SEPARATE: .section custom_data,"aw",@progbits,unique,3{{$}} | ||
// SEPARATE: i: | ||
// SEPARATE: .section custom_data,"aw",@progbits,unique,4{{$}} | ||
// SEPARATE: j: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -733,15 +733,20 @@ calcUniqueIDUpdateFlagsAndSize(const GlobalObject *GO, StringRef SectionName, | |
Ctx.isELFGenericMergeableSection(SectionName); | ||
// If this is the first ocurrence of this section name, treat it as the | ||
// generic section | ||
if (!SymbolMergeable && !SeenSectionNameBefore) | ||
return MCContext::GenericSectionID; | ||
if (!SymbolMergeable && !SeenSectionNameBefore) { | ||
if (TM.getSeparateNamedSections()) | ||
return NextUniqueID++; | ||
else | ||
return MCContext::GenericSectionID; | ||
} | ||
|
||
// Symbols must be placed into sections with compatible entry sizes. Generate | ||
// unique sections for symbols that have not been assigned to compatible | ||
// sections. | ||
const auto PreviousID = | ||
Ctx.getELFUniqueIDForEntsize(SectionName, Flags, EntrySize); | ||
if (PreviousID) | ||
if (PreviousID && (!TM.getSeparateNamedSections() || | ||
*PreviousID == MCContext::GenericSectionID)) | ||
return *PreviousID; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. drop braces for one-line single statement There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
|
||
// If the user has specified the same section name as would be created | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
; Test that global values with explicit sections are placed into unique sections. | ||
|
||
; RUN: llc < %s | FileCheck %s | ||
; RUN: llc -separate-named-sections < %s | FileCheck %s --check-prefix=SEPARATE | ||
target triple="x86_64-unknown-unknown-elf" | ||
|
||
define i32 @f() section "custom_text" { | ||
entry: | ||
ret i32 0 | ||
} | ||
|
||
define i32 @g() section "custom_text" { | ||
entry: | ||
ret i32 0 | ||
} | ||
|
||
; CHECK: .section custom_text,"ax",@progbits{{$}} | ||
; CHECK: f: | ||
; CHECK: g: | ||
|
||
; SEPARATE: .section custom_text,"ax",@progbits,unique,1{{$}} | ||
; SEPARATE: f: | ||
; SEPARATE: .section custom_text,"ax",@progbits,unique,2{{$}} | ||
; SEPARATE: g: | ||
|
||
@i = global i32 0, section "custom_data", align 8 | ||
@j = global i32 0, section "custom_data", align 8 | ||
|
||
; CHECK: .section custom_data,"aw",@progbits{{$}} | ||
; CHECK: i: | ||
; CHECK: j: | ||
|
||
; SEPARATE: .section custom_data,"aw",@progbits,unique,3{{$}} | ||
; SEPARATE: i: | ||
; SEPARATE: .section custom_data,"aw",@progbits,unique,4{{$}} | ||
; SEPARATE: j: |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost all of the other flags have Doxygen comments. Worth something like:
/// Emit named sections with the same name into different sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done