[NFC] add explanation to register flags doc #91803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
arsenm
approved these changes
May 14, 2024
|
|
||
| * - ``early-clobber`` | ||
| - ``RegState::EarlyClobber`` | ||
| - Register definition happens before uses. |
There was a problem hiding this comment.
This one probably needs more elaboration
|
|
||
| * - ``renamable`` | ||
| - ``RegState::Renamable`` | ||
| - Register that may be renamed. |
There was a problem hiding this comment.
Also probably needs more explanation
These are just copy pasted from the enum value comments |
Where I usually go to refer to them, and still don't understand what renamable actually does |
arsenm
reviewed
May 14, 2024
| @@ -540,6 +540,9 @@ Register Flags | |||
| The table below shows all of the possible register flags along with the | |||
| corresponding internal ``llvm::RegState`` representation: | |||
|
|
|||
| .. | |||
| Keep this in sync with MachineInstrBuilder.h | |||
There was a problem hiding this comment.
Does this appear in the generated output?
There was a problem hiding this comment.
arsenm
approved these changes
May 14, 2024
fmayer
deleted the
users/fmayer/spr/nfc-add-explanation-to-register-flags-doc
branch
fmayer
added a commit
to fmayer/llvm-project
that referenced
this pull request
Sep 13, 2024
Pull Request: llvm#91803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.