Skip to content

Fix null pointer dereference in logging in mlir TransformOps #92237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix null pointer dereference in logging in mlir TransformOps #92237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mlir/lib/Dialect/Transform/IR/TransformOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,13 +648,14 @@ LogicalResult transform::ApplyConversionPatternsOp::verify() {
if (!llvm::hasSingleElement(typeConverterRegion.front()))
return emitOpError()
<< "expected exactly one op in default type converter region";
Operation *maybeTypeConverter = &typeConverterRegion.front().front();
auto typeConverterOp = dyn_cast<transform::TypeConverterBuilderOpInterface>(
&typeConverterRegion.front().front());
maybeTypeConverter);
if (!typeConverterOp) {
InFlightDiagnostic diag = emitOpError()
<< "expected default converter child op to "
"implement TypeConverterBuilderOpInterface";
diag.attachNote(typeConverterOp->getLoc()) << "op without interface";
diag.attachNote(maybeTypeConverter->getLoc()) << "op without interface";
return diag;
}
// Check default type converter type.
Expand Down
Loading