[MLIR][Tensor][Trivial] Fix test for trivial folding of tensor.insert_slice #92889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_slice The test in `@trivial_insert_slice` checks for the absence of `tensor.extract_slice`, although the test neither originally contains this operation before canonicalization, nor would this operation be produced. Instead, the check should ensure the absence of `tensor.insert_slice`, which should be elided by the folder. This is likely to be a copy-and-paste error for the check above.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-tensor Author: Andi Drebes (andidr) ChangesThe test in This is likely to be a copy-and-paste error for the check above. Full diff: https://github.com/llvm/llvm-project/pull/92889.diff 1 Files Affected:
diff --git a/mlir/test/Dialect/Tensor/canonicalize.mlir b/mlir/test/Dialect/Tensor/canonicalize.mlir
index 914e5e8b8c4b8..89259e4d47ad3 100644
--- a/mlir/test/Dialect/Tensor/canonicalize.mlir
+++ b/mlir/test/Dialect/Tensor/canonicalize.mlir
@@ -533,7 +533,7 @@ func.func @trivial_slice(%arg0 : tensor<4x6x16x32xi8>) -> tensor<4x6x16x32xi8> {
// CHECK-LABEL: func @trivial_insert_slice
// CHECK-SAME: %[[ARG0:.[a-z0-9A-Z_]+]]: tensor<4x6x16x32xi8>
-// CHECK-NOT: tensor.extract_slice
+// CHECK-NOT: tensor.insert_slice
// CHECK: return %[[ARG0]] : tensor<4x6x16x32xi8>
func.func @trivial_insert_slice(%arg0 : tensor<4x6x16x32xi8>, %arg1 : tensor<4x6x16x32xi8>) -> tensor<4x6x16x32xi8> {
%0 = tensor.insert_slice %arg0 into %arg1[0, 0, 0, 0] [4, 6, 16, 32] [1, 1, 1, 1] : tensor<4x6x16x32xi8> into tensor<4x6x16x32xi8>
|
|
Adding @matthias-springer to the discussion, who seems have adapted the test in commit 060208b. |
matthias-springer
approved these changes
May 21, 2024
joker-eph
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test in
@trivial_insert_slicechecks for the absence oftensor.extract_slice, although the test neither originally contains this operation before canonicalization, nor would this operation be produced. Instead, the check should ensure the absence oftensor.insert_slice, which should be elided by the folder.This is likely to be a copy-and-paste error for the check above.