[lldb] Fixed PlatformPOSIX::DoLoadImage() in case of the Windows host #93345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesPlatformPOSIX::DoLoadImage() failed on the Linux AArch64 target. It is related to the issue #93092. Disable the TestCompletion.test_process_unload test for now. Full diff: https://github.com/llvm/llvm-project/pull/93345.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/completion/TestCompletion.py b/lldb/test/API/functionalities/completion/TestCompletion.py
index 15aeaf8d0e897..eadb510a3df26 100644
--- a/lldb/test/API/functionalities/completion/TestCompletion.py
+++ b/lldb/test/API/functionalities/completion/TestCompletion.py
@@ -97,6 +97,9 @@ def test_process_load(self):
self.complete_from_to("process load Makef", "process load Makefile")
@skipUnlessPlatform(["linux"])
+ @expectedFailureAll(
+ archs=["aarch64"], bugnumber="github.com/llvm/llvm-project/issues/93092"
+ )
def test_process_unload(self):
"""Test the completion for "process unload <index>" """
# This tab completion should not work without a running process.
|
slydiman
force-pushed
the
fix2-lldb-TestCompletion
branch
from
3dcd666 to
76a35a6
Compare
slydiman
changed the title
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Do not denormalize the path. This patch fixes llvm#93092. BTW, it would be great to be able to pass the style or triple to SBFileSpec. Currently it is impossible to create a posix FileSpec on the Windows host.
slydiman
force-pushed
the
fix2-lldb-TestCompletion
branch
from
76a35a6 to
8701bfc
Compare
labath
approved these changes
May 27, 2024
| @@ -678,8 +678,8 @@ uint32_t PlatformPOSIX::DoLoadImage(lldb_private::Process *process, | |||
| loaded_image->Clear(); | |||
|
|
|||
| std::string path; | |||
There was a problem hiding this comment.
Suggested change
| std::string path; | |
| std::string path = remote_file.GetPath(false); |
Might as well fold the assignment into the declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not denormalize the path. This patch fixes #93092.
BTW, it would be great to be able to pass the style or triple to SBFileSpec. Currently it is impossible to create a posix SBFileSpec on the Windows host.