Fix the dsymutil heuristic for excluding system interfaces. #93745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
adrian-prantl
force-pushed
the
128571037
branch
2 times, most recently
from
e267a1a to
7dd2534
Compare
adrian-prantl
force-pushed
the
128571037
branch
2 times, most recently
from
0dd9089 to
ad3dce4
Compare
The function was meant to find the Developer/ dir, but it found a Developer directory nested deep inside the top-level Developer dir. The new implementation rejects everything in Xcode.app/Developer in broad strokes. rdar://128571037
adrian-prantl
added a commit
to adrian-prantl/llvm-project
that referenced
this pull request
May 30, 2024
The function was meant to find the Developer/ dir, but it found a Developer directory nested deep inside the top-level Developer dir. The new implementation rejects everything in Xcode.app/Developer in broad strokes. rdar://128571037 (cherry picked from commit f8cc183) Conflicts: llvm/lib/DWARFLinker/Classic/DWARFLinker.cpp llvm/lib/DWARFLinker/Parallel/DWARFLinkerCompileUnit.cpp
adrian-prantl
added a commit
to swiftlang/llvm-project
that referenced
this pull request
May 31, 2024
Fix the dsymutil heuristic for excluding system interfaces. (llvm#93745)
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Jun 3, 2024
The function was meant to find the Developer/ dir, but it found a Developer directory nested deep inside the top-level Developer dir. The new implementation rejects everything in Xcode.app/Developer in broad strokes. rdar: //128571037 Change-Id: Ieab957577601374237eea95dd07db01c131912d8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was meant to find the Developer/ dir, but it found a Developer directory nested deep inside the top-level Developer dir.
The new implementation rejects everything in Xcode.app/Developer in broad strokes.
rdar://128571037