-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[lldb] Add Python requirements.txt for test suite #94220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This means that CI won't have to hardcode these. We can't do conditional installs here by platform so pexpect is listed normally. If it's installed on Windows that's fine, we just won't use it.
@llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) ChangesThis means that CI won't have to hardcode these. We can't do conditional installs here by platform so pexpect is listed normally. If it's installed on Windows that's fine, we just won't use it. Full diff: https://github.com/llvm/llvm-project/pull/94220.diff 1 Files Affected:
diff --git a/lldb/requirements.txt b/lldb/requirements.txt
new file mode 100644
index 0000000000000..645004bd3f57c
--- /dev/null
+++ b/lldb/requirements.txt
@@ -0,0 +1,7 @@
+# These Python packages are required to be able to run the LLDB test suite.
+
+psutil
+# pexpect is only required on Linux, can be installed on Windows but pexpect
+# tests are automatically skipped there because they are known not to work
+# (llvm.org/pr22274).
+pexpect
|
I've not been able to find what versioning scheme these 2 packages use, so I'm not sure what versions to put here if any. Currently Linaro has: I don't think it needs to be This is initially for Github CI, so we could just use the Linux versions. |
Example from MLIR: llvm-project/mlir/python/requirements.txt Lines 1 to 3 in a58dd0e
|
I think you can list them as minimal required versions for now. |
Added minimum versions. |
Anecdotal evidence - last time I updated these I just installed the most recent and nothing broke. So we're probably fine with minimums, especially as this will be checked regularly by the CI job. |
I was wrong, you can do conditionals - https://peps.python.org/pep-0508/. pexpect now not installed on Windows. |
This means that CI won't have to hardcode these.