Skip to content

[mlir][Transforms][NFC] Improve dialect conversion documentation #94736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2024
Merged

[mlir][Transforms][NFC] Improve dialect conversion documentation #94736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions mlir/include/mlir/Transforms/DialectConversion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,8 +1088,9 @@ struct ConversionConfig {

/// An optional listener that is notified about all IR modifications in case
/// dialect conversion succeeds. If the dialect conversion fails and no IR
/// modifications are visible (i.e., they were all rolled back), no
/// notifications are sent.
/// modifications are visible (i.e., they were all rolled back), or if the
/// dialect conversion is an "analysis conversion", no notifications are
/// sent (apart from `notifyPatternBegin`/notifyPatternEnd`).
///
/// Note: Notifications are sent in a delayed fashion, when the dialect
/// conversion is guaranteed to succeed. At that point, some IR modifications
Expand Down
Loading