Skip to content

[libclang/python] Change minimum Python test version to 3.8 #95210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

DeinAlptraum
Copy link
Contributor

This fixes #95209

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Jun 12, 2024

@llvm/pr-subscribers-github-workflow

Author: Jannick Kremer (DeinAlptraum)

Changes

This fixes #95209


Full diff: https://github.com/llvm/llvm-project/pull/95210.diff

1 Files Affected:

  • (modified) .github/workflows/libclang-python-tests.yml (+1-1)
diff --git a/.github/workflows/libclang-python-tests.yml b/.github/workflows/libclang-python-tests.yml
index 497f6ca5c5547..43ded0af3ac21 100644
--- a/.github/workflows/libclang-python-tests.yml
+++ b/.github/workflows/libclang-python-tests.yml
@@ -36,7 +36,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.7", "3.11"]
+        python-version: ["3.8", "3.11"]
     uses: ./.github/workflows/llvm-project-tests.yml
     with:
       build_target: check-clang-python

@DeinAlptraum
Copy link
Contributor Author

@boomanaiden154 @Endilll hope you are the right people to ping for this

Copy link
Contributor

@Endilll Endilll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wait for more approvals.

Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DeinAlptraum
Copy link
Contributor Author

I don't quite understand how the concurrency-cancelling thing works, but it seems that the test for 3.8 was cancelled... would be surprised if this fails, but just in case it would be nice if one of you could restart the bindings 3.8 test

@Endilll
Copy link
Contributor

Endilll commented Jun 13, 2024

Despite status not showing it, both Python 3.8 and 3.11 runs finished successfully across two different runs:
https://github.com/llvm/llvm-project/actions/runs/9479974893/attempts/2?pr=95210
https://github.com/llvm/llvm-project/actions/runs/9479974893/attempts/3?pr=95210

@Endilll Endilll merged commit 8f795fc into llvm:main Jun 13, 2024
9 of 11 checks passed
Copy link

@DeinAlptraum Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@DeinAlptraum DeinAlptraum deleted the pre-strict branch June 13, 2024 14:53
EthanLuisMcDonough pushed a commit to EthanLuisMcDonough/llvm-project that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[clang/python] check-clang-python currently fails due to outdated Python version
4 participants