Skip to content

[libc++] Upgrade to GCC 14 in the CI #95212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

philnik777
Copy link
Contributor

No description provided.

@EricWF
Copy link
Member

EricWF commented Jun 12, 2024

I think this looks good.

Nothing actually takes affect after your commit it, so I think it's fine to commit and the we can build a test image and try deploying it.

@EricWF EricWF self-requested a review June 12, 2024 21:02
@philnik777
Copy link
Contributor Author

This is still waiting on libc++abi being fixed, so I'd rather wait on actually landing it.

@philnik777 philnik777 marked this pull request as ready for review June 30, 2024 10:14
@philnik777 philnik777 requested a review from a team as a code owner June 30, 2024 10:14
@philnik777 philnik777 merged commit f190343 into llvm:main Jun 30, 2024
11 of 13 checks passed
@philnik777 philnik777 deleted the gcc14_ci branch June 30, 2024 10:14
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jun 30, 2024
@llvmbot
Copy link
Member

llvmbot commented Jun 30, 2024

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/95212.diff

2 Files Affected:

  • (modified) libcxx/utils/ci/Dockerfile (+2-5)
  • (modified) libcxx/utils/ci/docker-compose.yml (+3-4)
diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index f9e89c80435fe..86a2c3a9502d4 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -91,11 +91,11 @@ RUN sudo apt-get update \
         make \
         python3 \
         python3-dev \
-        python3-distutils \
         python3-packaging \
+        python3-setuptools \
         python3-psutil \
         software-properties-common \
-        swig4.0 \
+        swig \
         unzip \
         uuid-dev \
         wget \
@@ -290,6 +290,3 @@ FROM builder-base AS actions-builder
 
 WORKDIR /home/runner
 USER runner
-
-
-
diff --git a/libcxx/utils/ci/docker-compose.yml b/libcxx/utils/ci/docker-compose.yml
index 28140038725d5..df5df8ce907f1 100644
--- a/libcxx/utils/ci/docker-compose.yml
+++ b/libcxx/utils/ci/docker-compose.yml
@@ -1,7 +1,7 @@
 version: '3.7'
 
 x-versions: &compiler_versions
-  GCC_LATEST_VERSION: 13
+  GCC_LATEST_VERSION: 14
   LLVM_HEAD_VERSION: 19
 
 services:
@@ -12,7 +12,7 @@ services:
       dockerfile: Dockerfile
       target: buildkite-builder
       args:
-        BASE_IMAGE: ubuntu:jammy
+        BASE_IMAGE: ubuntu:noble
         <<: *compiler_versions
   actions-builder:
     image: ghcr.io/libcxx/actions-builder:${TAG:-latest}
@@ -30,9 +30,8 @@ services:
       dockerfile: Dockerfile
       target: android-buildkite-builder
       args:
-        BASE_IMAGE: ubuntu:jammy
+        BASE_IMAGE: ubuntu:noble
         ANDROID_CLANG_VERSION: r498229b
         ANDROID_CLANG_PREBUILTS_COMMIT: 5186d132c99aa75dc25207c392e3ea5b93d0107e
         ANDROID_SYSROOT_BID: 10957860
         <<: *compiler_versions
-

lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants