[Flang][OpenMP] Fix type in getBaseObject causing crashes in certain scenarios #95472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scenarios This type would unfortunately cause code like the following to ICE, where common block symbols/names are used in a map clause: subroutine sb() implicit none integer:: b, c common /var/ b, c !$omp target map(tofrom: /var/) b = 1 c = 2 !$omp end target end subroutine
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-fir-hlfir Author: None (agozillon) ChangesThis typo would unfortunately cause code like the following to ICE, where common block symbols/names are used in a map clause: subroutine sb() !$omp target map(tofrom: /var/) Full diff: https://github.com/llvm/llvm-project/pull/95472.diff 1 Files Affected:
diff --git a/flang/lib/Lower/OpenMP/Clauses.cpp b/flang/lib/Lower/OpenMP/Clauses.cpp
index 1e3fea7c4cdc7..6bae62cd85860 100644
--- a/flang/lib/Lower/OpenMP/Clauses.cpp
+++ b/flang/lib/Lower/OpenMP/Clauses.cpp
@@ -153,7 +153,7 @@ Object makeObject(const parser::OmpObject &object,
std::optional<Object> getBaseObject(const Object &object,
semantics::SemanticsContext &semaCtx) {
// If it's just the symbol, then there is no base.
- if (!object.id())
+ if (!object.ref())
return std::nullopt;
auto maybeRef = evaluate::ExtractDataRef(*object.ref());
|
kparzysz
approved these changes
Jun 14, 2024
|
Thanks for the fix! |
|
@kparzysz Thank you for the quick review and handling the merge! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This typo would unfortunately cause code like the following to ICE, where common block symbols/names are used in a map clause:
subroutine sb()
implicit none
integer:: b, c
common /var/ b, c
!$omp target map(tofrom: /var/)
b = 1
c = 2
!$omp end target
end subroutine