Reapply "[libc] printf, putchar and vprintf in bareemetal entrypoints… #95619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llvm#95436)" This reverts commit eca988a. The underlying libc issue was fixed by PR#95576.
|
@llvm/pr-subscribers-libc Author: Haowei (zeroomega) ChangesThis reverts commit eca988a. The underlying libc issue was fixed by PR#95576. The original PR is #95436 , which adds printf, putchar and vprintf in bareemetal entrypoints Full diff: https://github.com/llvm/llvm-project/pull/95619.diff 2 Files Affected:
diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt
index 7fb82c60a1bb8..2930d718fdb21 100644
--- a/libc/config/baremetal/arm/entrypoints.txt
+++ b/libc/config/baremetal/arm/entrypoints.txt
@@ -80,8 +80,11 @@ set(TARGET_LIBC_ENTRYPOINTS
# stdio.h entrypoints
libc.src.stdio.remove
+ libc.src.stdio.printf
+ libc.src.stdio.putchar
libc.src.stdio.sprintf
libc.src.stdio.snprintf
+ libc.src.stdio.vprintf
libc.src.stdio.vsprintf
libc.src.stdio.vsnprintf
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index b769b43f03a2c..6d38676b1e8a8 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -80,8 +80,11 @@ set(TARGET_LIBC_ENTRYPOINTS
# stdio.h entrypoints
libc.src.stdio.remove
+ libc.src.stdio.printf
+ libc.src.stdio.putchar
libc.src.stdio.sprintf
libc.src.stdio.snprintf
+ libc.src.stdio.vprintf
libc.src.stdio.vsprintf
libc.src.stdio.vsnprintf
|
petrhosek
approved these changes
Jun 14, 2024
michaelrj-google
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eca988a. The underlying libc issue was fixed by PR#95576.
The original PR is #95436 , which adds printf, putchar and vprintf in bareemetal entrypoints