Skip to content

[NFC] fix incorrect #endif comment #95991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

fmayer
Copy link
Contributor

@fmayer fmayer commented Jun 18, 2024

No description provided.

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Jun 18, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Florian Mayer (fmayer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/95991.diff

1 Files Affected:

  • (modified) compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp (+2-2)
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
index d15caa76efb06..2c8681d99a1bd 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
@@ -1180,7 +1180,7 @@ uptr ReadBinaryName(/*out*/ char *buf, uptr buf_len) {
   uptr module_name_len = internal_readlink(default_module_name, buf, buf_len);
   int readlink_error;
   bool IsErr = internal_iserror(module_name_len, &readlink_error);
-#    endif  // SANITIZER_SOLARIS
+#    endif  // SANITIZER_FREEBSD || SANITIZER_NETBSD
   if (IsErr) {
     // We can't read binary name for some reason, assume it's unknown.
     Report(
@@ -1192,7 +1192,7 @@ uptr ReadBinaryName(/*out*/ char *buf, uptr buf_len) {
     CHECK_LT(module_name_len, buf_len);
   }
   return module_name_len;
-#  endif
+#  endif    // SANITIZER_SOLARIS
 }
 
 uptr ReadLongProcessName(/*out*/ char *buf, uptr buf_len) {

@fmayer fmayer requested a review from thurstond June 18, 2024 21:08
Created using spr 1.3.4
@fmayer fmayer merged commit 7a49c90 into main Jun 20, 2024
4 of 5 checks passed
@fmayer fmayer deleted the users/fmayer/spr/nfc-fix-incorrect-endif-comment branch June 20, 2024 20:32
AlexisPerry pushed a commit to llvm-project-tlp/llvm-project that referenced this pull request Jul 9, 2024
fmayer added a commit to fmayer/llvm-project that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants