[llvm-cov] let text mode divider honor --show-branch-summary --show-region-summary etc

[whentojump]

Otherwise it would be unnecessarily too long

Before

After

[hanickadot]

You need to fix tests for things you changed in llvm-cov.

[whentojump]

Oh I just realized file reports and function reports are using two different *Columns arrays...

[hanickadot]

I also wonder why missed functions is not colored. But it's not about your PR.

[whentojump]

I also wonder why missed functions is not colored. But it's not about your PR.

Right now the three columns for functions and for instantiations are [not colored, not colored, colored]

For all others, [not colored, colored, colored]

llvm-project/llvm/tools/llvm-cov/CoverageReport.cpp

Lines 237 to 263 in 99c43e3

	OS << format("%*u", FileReportColumns[4],
	(unsigned)File.FunctionCoverage.getNumFunctions());
	OS << format("%*u", FileReportColumns[5],
	(unsigned)(File.FunctionCoverage.getNumFunctions() -
	File.FunctionCoverage.getExecuted()));
	if (File.FunctionCoverage.getNumFunctions())
	Options.colored_ostream(OS, FuncCoverageColor)
	<< format("%*.2f", FileReportColumns[6] - 1,
	File.FunctionCoverage.getPercentCovered())
	<< '%';
	else
	OS << column("-", FileReportColumns[6], Column::RightAlignment);
	if (Options.ShowInstantiationSummary) {
	OS << format("%*u", FileReportColumns[7],
	(unsigned)File.InstantiationCoverage.getNumFunctions());
	OS << format("%*u", FileReportColumns[8],
	(unsigned)(File.InstantiationCoverage.getNumFunctions() -
	File.InstantiationCoverage.getExecuted()));
	if (File.InstantiationCoverage.getNumFunctions())
	Options.colored_ostream(OS, InstantiationCoverageColor)
	<< format("%*.2f", FileReportColumns[9] - 1,
	File.InstantiationCoverage.getPercentCovered())
	<< '%';
	else
	OS << column("-", FileReportColumns[9], Column::RightAlignment);
	}

Don't know why either... :)

[hanickadot]

LGTM