[ValueTypes][NFC] Generate EVT::getTypeForEVT from GenVT.inc #96608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of MVT has simple mapping to the LLVM type, so it would be nice to auto generate that from ValueTypes.td, that could reduce the effort when we adding new MVT, especially new vector MVT with different size.
arsenm
reviewed
Jun 25, 2024
arsenm
reviewed
Jun 25, 2024
arsenm
reviewed
Jun 25, 2024
arsenm
reviewed
Jun 25, 2024
topperc
reviewed
Jun 25, 2024
topperc
reviewed
Jun 25, 2024
topperc
reviewed
Jun 26, 2024
topperc
reviewed
Jun 26, 2024
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of MVT has simple mapping to the LLVM type, so it would be nice to auto generate that from ValueTypes.td, that could reduce the effort when we adding new MVT, especially new vector MVT with different size.