[emacs] More consistently highlight value keywords that appear in vectors #97594
Conversation
…tors Previously something like `<i8 123, i8 poison>` would not properly highlight the `poison` keyword at the end.
goldsteinn
force-pushed
the
goldsteinn/emacs-highlight-vec-values
branch
from
de02c29 to
95b04ff
Compare
| @@ -61,6 +61,8 @@ | |||
| `(,(concat "\\<" llvm-mode-primitive-type-regexp "\\>") . font-lock-type-face) | |||
| ;; Integer literals | |||
| '("\\b[-]?[0-9]+\\b" . font-lock-preprocessor-face) | |||
| ;; Values that can appear in a vec | |||
| '("\\b\\(true\\|false\\|null\\|undef\\|poison\\|none\\)\\b" . font-lock-keyword-face) | |||
There was a problem hiding this comment.
I wonder if the 'words paren argument to regexp-opt would also work? https://www.gnu.org/software/emacs/manual/html_node/elisp/Regexp-Functions.html#index-regexp_002dopt
`(,(regexp-opt '("true" "false" "null" "undef" "none" "poison") 'words) . font-lock-keyword-faceThere was a problem hiding this comment.
Let me check.
BTW, first I tried (mapconcat 'identity '("true" "false" "null" "undef" "none" "poison") "//|") for the list but that didn't work, any idea why?
There was a problem hiding this comment.
doesn't seem to work.
There was a problem hiding this comment.
BTW, first I tried
(mapconcat 'identity '("true" "false" "null" "undef" "none" "poison") "//|")for the list but that didn't work, any idea why?
Did you mean \\|?
There was a problem hiding this comment.
doesn't seem to work.
Ah well, was worth a shot
There was a problem hiding this comment.
Full code:
'((concat "\\b\\(" (mapconcat 'identity '("true" "false" "null" "undef" "none" "poison") "\\|") "\\)\\b") . font-lock-keyword-face)
There was a problem hiding this comment.
Err that doesn't work, any idea why?
There was a problem hiding this comment.
No idea. Evaluating your snippet gives me "\\b\\(true\\|false\\|null\\|undef\\|none\\|poison\\)\\b" which is the same as whats in this PR, but none and poison are swapped around?
There was a problem hiding this comment.
Yeah, I don't know either, cest la vie, ill merge this as is.
…tors (llvm#97594) Previously something like `<i8 123, i8 poison>` would not properly highlight the `poison` keyword at the end.
Previously something like
<i8 123, i8 poison>would not properlyhighlight the
poisonkeyword at the end.